launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+465565@xxxxxxxxxxxxxxxxxx>]

Quentin Debhi has proposed merging ~ruinedyourlife/launchpad:feat-update-gitignore into launchpad:master.

Commit message:
Ignore vscode files and tidying up

Adding `launch.json` to `.gitignore` for vscode users, which allows for tests configuration in the first place. Also tidy up what's already existing.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/465565
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:feat-update-gitignore into launchpad:master.

diff --git a/.gitignore b/.gitignore
index 82f290a..dfef53c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,37 +1,30 @@
+# compiled python files
 *.pyc
+
+# tags
 .tags
+/tags
+TAGS
+tags.new
+
+# version files
 version-info.py
 version-info.txt
+
+# log files
 logs/*
-+*
-/botmaster
-/tags
-database/schema/diagrams/*.ps
-database/schema/diagrams/*.dot
-thread*.request
-TAGS
-cover.txt
-.shelf
-development-nohup.out
-opensource/launchpadlib/build
-opensource/launchpadlib/dist
-opensource/launchpadlib/*.egg*
-database/sampledata/newsampledata.sql
-database/sampledata/newsampledata-dev.sql
-database/sampledata/lintdata.sql
-database/sampledata/lintdata-dev.sql
-lib/canonical/launchpad/apidoc/*.html
-xxx-report.*
-lib/canonical/launchpad/apidoc/wadl-development-*.xml
-lib/canonical/launchpad/apidoc/wadl-test-playground.xml
-lib/canonical/launchpad/icing/build/*
-lib/canonical/launchpad/icing/base.css
-lib/canonical/launchpad/icing/base.css.map
-lib/canonical/launchpad/icing/combo.css
-lib/canonical/launchpad/icing/combo.css.map
-bin
-.installed.cfg
-parts
+!logs/README.txt
+/logs
+librarian.log
+
+# development tools configurations
+.project
+.pydevproject
+.idea
+.emacs.desktop
+.vscode
+
+# build artifacts
 *.egg-info
 build
 dist
@@ -39,40 +32,74 @@ dist
 /download-cache
 /env
 /production-configs
-bzr.dev
-_trial_temp
-.bazaar
+bin
+.installed.cfg
+parts
+
+# specific software or tools
+.tox/
+/geckodriver.log
 .cache
 .subversion
 .testrepository
+.bazaar
 .memcache.pid
-lib/canonical/launchpad/apidoc/wadl-development-*.xml
-tags.new
-lp-clustered.dot
-lp-clustered.sfood
-lp-clustered.svg
-lp.sfood
-apidocs
 twistd.pid
+_trial_temp
+/celerybeat-schedule
+requirements/combined.txt
+
+# revision control systems
+bzr.dev
+
+# launchpad specific
 lib/canonical/launchpad/apidoc
-*.prof
-.project
-.pydevproject
-librarian.log
-configs/testrunner_*
-configs/testrunner-appserver_*
-.idea
-run.gdb
+lib/canonical/launchpad/apidoc/*.html
+lib/canonical/launchpad/apidoc/wadl-development-*.xml
+lib/canonical/launchpad/apidoc/wadl-test-playground.xml
+lib/canonical/launchpad/icing/build/*
+lib/canonical/launchpad/icing/base.css
+lib/canonical/launchpad/icing/base.css.map
+lib/canonical/launchpad/icing/combo.css
+lib/canonical/launchpad/icing/combo.css.map
 lib/canonical/launchpad/icing/*-sprites-*.png
 lib/canonical/launchpad/icing/*.positioning
 lib/canonical/launchpad/icing/yui
-.emacs.desktop
+
+# database schemas and sample data
+database/schema/diagrams/*.ps
+database/schema/diagrams/*.dot
+database/sampledata/newsampledata.sql
+database/sampledata/newsampledata-dev.sql
+database/sampledata/lintdata.sql
+database/sampledata/lintdata-dev.sql
+
+# source and development files
+thread*.request
+cover.txt
+.shelf
+development-nohup.out
+opensource/launchpadlib/build
+opensource/launchpadlib/dist
+opensource/launchpadlib/*.egg*
+
+# profiling and debugging
+*.prof
 callgrind.out.*
-/celerybeat-schedule
-!logs/README.txt
-/logs
+run.gdb
+
+# node and python packages
 yarn/node_modules
 /wheels
-requirements/combined.txt
-.tox/
-/geckodriver.log
+
+# misc
++*
+/botmaster
+xxx-report.*
+lp-clustered.dot
+lp-clustered.sfood
+lp-clustered.svg
+lp.sfood
+apidocs
+configs/testrunner_*
+configs/testrunner-appserver_*