launchpad-reviewers team mailing list archive

[Ines Almeida <mp+466800@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:revert-appserver-hourly-changes into launchpad:master.

Commit message:
Revert "charm: update appserver logrotate from daily to hourly"
    
This reverts commit 5b7bfde6e699416f12c7eaa372fd6b979c5a3254.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/466800

MP reverted: https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/464017

Details already in Jira ticket: https://warthogs.atlassian.net/browse/LP-1651
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:revert-appserver-hourly-changes into launchpad:master.

diff --git a/charm/launchpad-appserver/templates/logrotate.conf.j2 b/charm/launchpad-appserver/templates/logrotate.conf.j2
index 2714525..494f246 100644
--- a/charm/launchpad-appserver/templates/logrotate.conf.j2
+++ b/charm/launchpad-appserver/templates/logrotate.conf.j2
@@ -1,9 +1,8 @@
 {{ logs_dir }}/launchpad.log
 {
-    rotate 504
-    hourly
+    rotate 21
+    daily
     dateext
-    dateformat -%Y%m%d-%H
     delaycompress
     compress
     notifempty