← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~ines-almeida/launchpad:db-snap-pro-enable-constraints into launchpad:db-devel

 

The proposal to merge ~ines-almeida/launchpad:db-snap-pro-enable-constraints into launchpad:db-devel has been updated.

Commit message changed to:

db: update snap.pro_enable schema change to add default false statement

This is relevant so that there is never a time that the value is NULL while creating the snap, which is scenario that can happen while setting the multiple snap fields when creating a new snap - if snap.pro_enable is set after snap.branch (which runs a validator that accesses the DB), then the null constraint will fail because snap.pro_enable is null (instead of false).
This change prevents any of such issues.

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/467136
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:db-snap-pro-enable-constraints into launchpad:db-devel.



References