← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~tushar5526/launchpad-buildd:bump-pre-commit-deps into launchpad-buildd:master

 

Tushar Gupta has proposed merging ~tushar5526/launchpad-buildd:bump-pre-commit-deps into launchpad-buildd:master.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~tushar5526/launchpad-buildd/+git/launchpad-buildd/+merge/469681

Ran pre-commit autoupdate, followed by a pre-commit run on all files.

flake8 was throwing up formatting errors for valid URL strings and needed a version bump for python3.12
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~tushar5526/launchpad-buildd:bump-pre-commit-deps into launchpad-buildd:master.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index f8186f4..11838b6 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -1,6 +1,6 @@
 repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.6.0
     hooks:
     -   id: check-added-large-files
     -   id: check-merge-conflict
@@ -8,7 +8,7 @@ repos:
     -   id: check-yaml
     -   id: debug-statements
 -   repo: https://github.com/asottile/pyupgrade
-    rev: v3.3.1
+    rev: v3.16.0
     hooks:
     -   id: pyupgrade
         args: [--py36-plus]
@@ -16,20 +16,20 @@ repos:
         # so it has different compatibility constraints.
         exclude: ^bin/lpbuildd-git-proxy$
 -   repo: https://github.com/psf/black
-    rev: 23.1.0
+    rev: 24.4.2
     hooks:
     -   id: black
 -   repo: https://github.com/PyCQA/isort
-    rev: 5.12.0
+    rev: 5.13.2
     hooks:
     -   id: isort
         name: isort
         args: [--profile, black]
 -   repo: https://github.com/PyCQA/flake8
-    rev: 6.0.0
+    rev: 7.1.0
     hooks:
     -   id: flake8
 -   repo: https://github.com/shellcheck-py/shellcheck-py
-    rev: v0.9.0.2
+    rev: v0.10.0.1
     hooks:
     -   id: shellcheck
diff --git a/lpbuildd/ci.py b/lpbuildd/ci.py
index 7886f38..bf762d5 100644
--- a/lpbuildd/ci.py
+++ b/lpbuildd/ci.py
@@ -272,9 +272,9 @@ class CIBuildManager(BuildManagerProxyMixin, DebianBuildManager):
                 entry_base = os.path.basename(entry)
                 name = os.path.join(self.current_job_id, entry_base)
                 self.addWaitingFileFromBackend(path, name=name)
-                job_status.setdefault("output", {})[
-                    entry_base
-                ] = self._builder.waitingfiles[name]
+                job_status.setdefault("output", {})[entry_base] = (
+                    self._builder.waitingfiles[name]
+                )
 
         # Save a file map for this job in the extra status file.  This
         # allows buildd-manager to fetch job logs/output incrementally
diff --git a/lpbuildd/target/build_livefs.py b/lpbuildd/target/build_livefs.py
index ed94328..d77e1cf 100644
--- a/lpbuildd/target/build_livefs.py
+++ b/lpbuildd/target/build_livefs.py
@@ -174,9 +174,9 @@ class BuildLiveFS(SnapStoreOperationMixin, Operation):
                     self.args.image_targets
                 )
             if self.args.repo_snapshot_stamp:
-                base_lb_env[
-                    "REPO_SNAPSHOT_STAMP"
-                ] = self.args.repo_snapshot_stamp
+                base_lb_env["REPO_SNAPSHOT_STAMP"] = (
+                    self.args.repo_snapshot_stamp
+                )
             if self.args.cohort_key:
                 base_lb_env["COHORT_KEY"] = self.args.cohort_key
             lb_env = base_lb_env.copy()