launchpad-reviewers team mailing list archive

[Guruprasad <mp+470363@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:update-ppa-signing-key-garbo-job-add-logging into launchpad:master.

Commit message:
Add debug logging to the UpdatePPASigningKeyFingerprintToRSA4096Key garbo job

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/470363
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:update-ppa-signing-key-garbo-job-add-logging into launchpad:master.

diff --git a/lib/lp/scripts/garbo.py b/lib/lp/scripts/garbo.py
index 63bc5b7..2e6beb4 100644
--- a/lib/lp/scripts/garbo.py
+++ b/lib/lp/scripts/garbo.py
@@ -2299,12 +2299,17 @@ class UpdatePPASigningKeyFingerprintToRSA4096Key(TunableLoop):
         rsa4096_key = archive_signing_key_set.get4096BitRSASigningKey(archive)
         if rsa4096_key:
             archive.signing_key_fingerprint = rsa4096_key.fingerprint
+        else:
+            self.log.debug(
+                f"Did not find an rsa4096 key for {archive.reference}."
+            )
 
     def isDone(self):
         return self.findAffectedArchives().is_empty()
 
     def __call__(self, chunk_size):
         for archive in self.findAffectedArchives()[:chunk_size]:
+            self.log.debug(f"Updating the signing key of {archive.reference}.")
             self.updateSigningKeyFingerprint(archive)
         transaction.commit()