launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel-candidate into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

To: Simone Pelosi <simone.pelosi@xxxxxxxxxxxxx>
From: Ines Almeida <mp+470432@xxxxxxxxxxxxxxxxxx>
Date: Thu, 01 Aug 2024 13:17:08 -0000
In-reply-to: <172243370415.531902.8135099753662541674.launchpad@scripts-bzrsyncd.lp.internal>
Reply-to: mp+470432@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I might not have the right context, but can you clarify the reason for pinning a `candidate` channel here? I notice we do it for riscv builders for example, but it would be nice to understand why in the commit message and perhaps as a commend in the code.

I'd also consider perhaps adding a `if qastaging` check for testing instead of going straight to production to be safe.
-- 
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/470432
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad-mojo-specs/+git/private:arm-builders-lxd-channel-candidate into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.