launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+470016@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
> index f400ef4..6a4d374 100644
> --- a/snap/snapcraft.yaml
> +++ b/snap/snapcraft.yaml
> @@ -66,6 +66,7 @@ parts:
>      stage-packages:
>        - git
>        - apt
> +      - distro-info-data

Why would we need distro-info both as python package and as deb? I prefer it to only use the python version.

>      # snapcraft uses venv, which doesn't pull in wheel (as opposed to virtualenv)
>      # so then 'pip install PyYAML' gets cross.
>      python-packages: [wheel]


-- 
https://code.launchpad.net/~andersson123/lpci/+git/lpci/+merge/470016
Your team Launchpad code reviewers is requested to review the proposed merge of ~andersson123/lpci:add-deb822-support into lpci:main.