launchpad-reviewers team mailing list archive

[Ines Almeida <mp+471743@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM, only a small comment to address

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index 87c5d1a..a05c15e 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -361,6 +361,25 @@ applications:
>        use_swift: false
>        visibility: private
>  {%- endif %}
> +{%- if stage_name == "qastaging" %}
> +  glance-simplestreams-sync-bos03-s390x:
> +    charm: {{ charm_dir }}/glance-simplestreams-sync
> +    constraints: "{{ extra_constraints }}"
> +    num_units: 1
> +    options:
> +      content_id_template: "{{ content_id_template }}"
> +      custom_properties: "hypervisor_type=kvm"
> +      mirror_list: |-
> +        [{url: "http://cloud-images.ubuntu.com/daily/";, name_prefix: "ubuntu:released", path: "streams/v1/index.sjson", max: 3, item_filters: ["release~({{ gss_series }})", "arch~(s390x)", "ftype~(disk1.img|disk.img)"]}]
> +      name_prefix: "{{ name_prefix }}/"
> +      openstack-auth-url: "http://keystone.ps6.canonical.com:5000/v3";

Shouldn't it be https?

> +      openstack-identity-api-version: "3"
> +      openstack-tenant-name: "{{ openstack_tenant_name_bos03 }}"
> +      openstack-username: "{{ openstack_username_bos03 }}"
> +      region: scalingstack-bos03
> +      use_swift: false
> +      visibility: private
> +{%- endif %}
>    glance-simplestreams-sync-lcy02-amd64:
>      charm: {{ charm_dir }}/glance-simplestreams-sync
>      constraints: "{{ extra_constraints }}"


-- 
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/471743
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.