launchpad-reviewers team mailing list archive

[Tushar Gupta <mp+472203@xxxxxxxxxxxxxxxxxx>]

Tushar Gupta has proposed merging ~tushar5526/launchpad-buildd:use-twisted-support into launchpad-buildd:master.

Commit message:
fix: use twisted support instead of deferred tests in testtools

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~tushar5526/launchpad-buildd/+git/launchpad-buildd/+merge/472203
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~tushar5526/launchpad-buildd:use-twisted-support into launchpad-buildd:master.

diff --git a/lpbuildd/tests/test_rock.py b/lpbuildd/tests/test_rock.py
index 64e376b..5c56b5c 100644
--- a/lpbuildd/tests/test_rock.py
+++ b/lpbuildd/tests/test_rock.py
@@ -1,10 +1,8 @@
-import base64
 import os
 
-import responses
 from fixtures import EnvironmentVariable, TempDir
 from testtools import TestCase
-from testtools.deferredruntest import AsynchronousDeferredRunTest
+from testtools.twistedsupport import AsynchronousDeferredRunTest
 from twisted.internet import defer
 
 from lpbuildd.rock import RockBuildManager, RockBuildState
@@ -24,7 +22,7 @@ class MockBuildManager(RockBuildManager):
             iterate = self.iterate
         self.iterators.append(iterate)
         return 0
-    
+
 
 class TestRockBuildManagerIteration(TestCase):
     """Run RockBuildManager through its iteration steps."""
diff --git a/lpbuildd/tests/test_source.py b/lpbuildd/tests/test_source.py
index 0f99fbe..6382be5 100644
--- a/lpbuildd/tests/test_source.py
+++ b/lpbuildd/tests/test_source.py
@@ -1,10 +1,8 @@
-import base64
 import os
 
-import responses
 from fixtures import EnvironmentVariable, TempDir
 from testtools import TestCase
-from testtools.deferredruntest import AsynchronousDeferredRunTest
+from testtools.twistedsupport import AsynchronousDeferredRunTest
 from twisted.internet import defer
 
 from lpbuildd.source import SourceBuildManager, SourceBuildState
@@ -24,7 +22,7 @@ class MockBuildManager(SourceBuildManager):
             iterate = self.iterate
         self.iterators.append(iterate)
         return 0
-    
+
 
 class TestSourceBuildManagerIteration(TestCase):
     """Run SourceBuildManager through its iteration steps."""
@@ -120,7 +118,8 @@ class TestSourceBuildManagerIteration(TestCase):
             log.write("I am a build log.")
 
         self.buildmanager.backend.add_file(
-            "/home/buildd/test-source/test-source_0_all.tar.xz", b"I am sourceing."
+            "/home/buildd/test-source/test-source_0_all.tar.xz",
+            b"I am sourceing.",
         )
 
         # After building the package, reap processes.