launchpad-reviewers team mailing list archive

[Guruprasad <mp+472757@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index 1dbddf2..96b8bd9 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -126,7 +126,7 @@
>  {%-   set lp_sshkey = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFrjt0yytzrK9fQuG+6VgE6QStUbDmunlN7+Lv5XhmoL stg-launchpad@launchpad-bastion-ps5" %}
>  {%-   set modifiers_bos01 = '{"arm64": "10.43.0.10", "ppc64el": "10.43.0.23", "s390x": "10.43.0.15"}' %}
>  {%-   set modifiers_bos02 = '{"arm64": "10.44.0.13", "ppc64el": "10.44.0.19", "s390x": "10.44.0.14"}' %}
> -{%-   set modifiers_bos03 = '{"amd64": "10.144.0.206", "arm64": "10.144.0.127", "riscv64": "10.144.0.114", "s390x": "10.144.0.47"}' %}
> +{%-   set modifiers_bos03 = '{"amd64": "10.144.0.206", "arm64": "10.144.0.127", "ppc64el": "10.144.0.110", riscv64": "10.144.0.114", "s390x": "10.144.0.47"}' %}

Afaics, the items are in alphabetical order in this dict and many others in the same file. This is a very common pattern in all our mojo specs and it makes it easy to search and find things. So I have used the same pattern. 

I am +1 for exploring other options like splitting the definition into multiple lines, but we can do that as a part of a separate change since I have already merged this after Tushar's review and approval. I hope that's okay.

>  {%-   set name_prefix = "launchpad-buildd-qastaging" %}
>  {%-   set openstack_tenant_name = "vbuilder_staging_project" %}
>  {%-   set openstack_tenant_name_bos03 = "launchpad-vbuilder-staging_project" %}


-- 
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472757
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.