launchpad-reviewers team mailing list archive

[Ines Almeida <mp+472801@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Looks good

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index d24573a..fa70489 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -137,8 +137,8 @@
>  {%-   set openstack_username = "vbuilder_staging" %}
>  {%-   set openstack_username_bos03 = "launchpad-vbuilder-staging" %}
>  {%-   set openstack_username_lcy02 = "launchpad-vbuilder-staging" %}
> -{%-   set vbuilders_bos01 = {"amd64": {"series": "focal", "flavor": "vbuilder-gpu", "count": 1}, "arm64-gpu": {"arch_base": "arm64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-nvidia-l4", "count": 1, "config_drive": false}, "ppc64el": {"series": "focal", "count": 1}, "s390x": {"series": "focal", "count": 1}} %}
> -{%-   set vbuilders_bos02 = {"ppc64el": {"series": "focal", "count": 1}, "s390x": {"series": "focal", "count": 1}} %}
> +{%-   set vbuilders_bos01 = {"amd64": {"series": "focal", "flavor": "vbuilder-gpu", "count": 1}, "arm64-gpu": {"arch_base": "arm64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-nvidia-l4", "count": 1, "config_drive": false}} %}
> +{%-   set vbuilders_bos02 = {} %}

So cool to see one of these empty :muscle:

>  {%-   set vbuilders_bos03 = {"amd64": {"series": "focal", "count": 4}, "amd64-gpu": {"arch_base": "amd64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-gpu", "count": 1}, "arm64": {"series": "focal", "count": 1, "config_drive": false, "flavor": "vbuilder-arm64"}, "ppc64el": {"series": "focal", "count": 3, "config_drive": false, "flavor": "vbuilder-ppc64el"}, "riscv64": {"series": "noble", "count": 1, "config_drive": false}, "s390x": {"series": "focal", "count": 3, "config_drive": false, "flavor": "vbuilder-s390x"}} %}
>  {%-   set vbuilders_lcy02 = {"amd64": {"series": "focal", "count": 4}} %}
>  {%-   set vbuilder_prefix = "qastaging-" %}


-- 
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472801
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.