launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #31419
[Merge] ~lgp171188/launchpad-mojo-specs/+git/private:vbuilder-fix-broken-bundle-production into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder
Guruprasad has proposed merging ~lgp171188/launchpad-mojo-specs/+git/private:vbuilder-fix-broken-bundle-production into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Commit message:
Convert a # comment to a jinja2 comment
Due to the usage of # for marking the comment, it got rendered into the
resulting bundle.yaml file in production and broke it because of a bad
interaction with manual whitespace control markers later in the file.
The 'series' top-level key got appended to this comment and juju errored
out since it is a required property.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~lgp171188/launchpad-mojo-specs/+git/private/+merge/472991
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad-mojo-specs/+git/private:vbuilder-fix-broken-bundle-production into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.
Follow ups