launchpad-reviewers team mailing list archive

[Tiago Nobrega <mp+472976@xxxxxxxxxxxxxxxxxx>]

Review: Approve

A quick turn-around! Thanks a lot

Diff comments:

> diff --git a/lpbuildd/target/build_snap.py b/lpbuildd/target/build_snap.py
> index 18af73a..b92127b 100644
> --- a/lpbuildd/target/build_snap.py
> +++ b/lpbuildd/target/build_snap.py
> @@ -226,8 +226,15 @@ class BuildSnap(
>              # jugmac00 reached out both to William and Claudio to figure out
>              self.install_svn_servers()
>          if self.args.use_fetch_service:
> +            # Deleting apt cache /var/lib/apt/lists before
> +            # installing the fetch service
> +            self.backend.run(
> +                ["rm", "-rf", "/var/lib/apt/lists/*"]
> +            )
>              self.install_mitm_certificate()
>              self.install_snapd_proxy(proxy_url=self.args.proxy_url)
> +            # Call apt update to refresh the apt cache
> +            self.backend.run(["apt-get", "-y", "update"])

The change itself looks fine (to me)! Thanks!

>              self.restart_snapd()
>  
>      def repo(self):


-- 
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/472976
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad-buildd:delete-apt-cache-before-craft-tools into launchpad-buildd:master.