launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+472806@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lpbuildd/target/build_livefs.py b/lpbuildd/target/build_livefs.py
> index d77e1cf..59e936b 100644
> --- a/lpbuildd/target/build_livefs.py
> +++ b/lpbuildd/target/build_livefs.py
> @@ -177,6 +206,10 @@ class BuildLiveFS(SnapStoreOperationMixin, Operation):
>                  base_lb_env["REPO_SNAPSHOT_STAMP"] = (
>                      self.args.repo_snapshot_stamp
>                  )
> +            if self.args.snapshot_service_timestamp:
> +                base_lb_env["SNAPSHOT_SERVICE_TIMESTAMP"] = (

I have to double check that, I don't know if the CPC team want to use this variable inside the chroot for something else

> +                    self.args.snapshot_service_timestamp
> +                )
>              if self.args.cohort_key:
>                  base_lb_env["COHORT_KEY"] = self.args.cohort_key
>              lb_env = base_lb_env.copy()


-- 
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/472806
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad-buildd:snapshot-service-integration-for-livefs-builds into launchpad-buildd:master.