launchpad-reviewers team mailing list archive

[Ines Almeida <mp+472970@xxxxxxxxxxxxxxxxxx>]

I'm slightly confused with this MP - the commit mentions adding logic to delete rock builds but then it seems to have a lot of other code - either due to conflicts or a wrong prerequisite branch, I assume.

I looked into the last commit hat seems to add deletion of rocks, and it generally made sense to me.

Diff comments:

> diff --git a/database/schema/security.cfg b/database/schema/security.cfg
> index 2c23fd6..a906e9a 100644
> --- a/database/schema/security.cfg
> +++ b/database/schema/security.cfg
> @@ -2917,3 +2917,34 @@ public.teammembership                   = SELECT
>  public.teamparticipation                = SELECT
>  public.webhook                          = SELECT
>  public.webhookjob                       = SELECT, INSERT
> +
> +[rock-build-job]

Why are we only adding this now? Shouldn't we have added it with the DB change?

> +type=user
> +groups=script
> +public.account                          = SELECT
> +public.builder                          = SELECT
> +public.buildfarmjob                     = SELECT, INSERT
> +public.buildqueue                       = SELECT, INSERT, UPDATE
> +public.rockfile                         = SELECT
> +public.rockrecipe                       = SELECT, UPDATE
> +public.rockrecipebuild                  = SELECT, INSERT, UPDATE
> +public.rockrecipebuildjob               = SELECT, UPDATE
> +public.rockrecipejob                    = SELECT, UPDATE
> +public.distribution                     = SELECT
> +public.distroarchseries                 = SELECT
> +public.distroseries                     = SELECT
> +public.emailaddress                     = SELECT
> +public.gitref                           = SELECT
> +public.gitrepository                    = SELECT
> +public.job                              = SELECT, INSERT, UPDATE
> +public.libraryfilealias                 = SELECT
> +public.libraryfilecontent               = SELECT
> +public.person                           = SELECT
> +public.personsettings                   = SELECT
> +public.pocketchroot                     = SELECT
> +public.processor                        = SELECT
> +public.product                          = SELECT
> +public.teammembership                   = SELECT
> +public.teamparticipation                = SELECT
> +public.webhook                          = SELECT
> +public.webhookjob                       = SELECT, INSERT


-- 
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/472970
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:delete-rock-recipe-builds-and-jobs-when-deleting-recipes into launchpad:master.