launchpad-reviewers team mailing list archive

[Ines Almeida <mp+473368@xxxxxxxxxxxxxxxxxx>]

Don't forget to allocate your patch in https://code.launchpad.net/~launchpad/+git/dbpatches

See 'how to/make a database patch' documentation: https://documentation.ubuntu.com/launchpad/en/latest/how-to/database-schema-changes-process/#making-a-database-patch

The patch itself looks good!

Diff comments:

> diff --git a/database/schema/patch-2211-29-0.sql b/database/schema/patch-2211-29-0.sql
> new file mode 100644
> index 0000000..a14c026
> --- /dev/null
> +++ b/database/schema/patch-2211-29-0.sql
> @@ -0,0 +1,10 @@
> +-- Copyright 2024 Canonical Ltd.  This software is licensed under the
> +-- GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +SET client_min_messages=ERROR;
> +
> +ALTER TABLE RockRecipe ADD COLUMN use_fetch_service boolean DEFAULT false NOT NULL;
> +
> +COMMENT ON COLUMN RockRecipe.use_fetch_service IS 'Whether to use the fetch-service in place of the builder-proxy when building this rock.';
> +
> +INSERT INTO LaunchpadDatabaseRevision VALUES (2211, 29, 0);
> \ No newline at end of file

Nit: in these files we usually have a blank line at the end



-- 
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/473368
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:add-fetch-service-column-to-RockRecipe into launchpad:db-devel.