launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+473468@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/launchpad:fix-rock-build-parser-tests into launchpad:master.

Commit message:
Fix rockcraft.yaml parser tests

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/473468
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:fix-rock-build-parser-tests into launchpad:master.

diff --git a/lib/lp/rocks/adapters/tests/test_buildarch.py b/lib/lp/rocks/adapters/tests/test_buildarch.py
index 0868f9c..cc4e147 100644
--- a/lib/lp/rocks/adapters/tests/test_buildarch.py
+++ b/lib/lp/rocks/adapters/tests/test_buildarch.py
@@ -343,17 +343,6 @@ class TestDetermineInstancesToBuild(WithScenarios, TestCaseWithFactory):
                 ),
             },
         ),
-        (
-            "no bases specified",
-            {
-                "bases": None,
-                "expected": [
-                    ("20.04", "amd64"),
-                    ("20.04", "arm64"),
-                    ("20.04", "riscv64"),
-                ],
-            },
-        ),
     ]
 
     def test_parser(self):
@@ -387,7 +376,6 @@ class TestDetermineInstancesToBuild(WithScenarios, TestCaseWithFactory):
             determine_instances_to_build,
             rockcraft_data,
             dases,
-            distro_serieses[0],
         )
         if hasattr(self, "expected_exception"):
             self.assertThat(