launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+473659@xxxxxxxxxxxxxxxxxx>]

Thanks a lot for proposing a patch to the fix.

I am not exactly sure, but I assume we have some tests covering that area, and I am currently running the test suite to figure out which tests need to be adapted, or where we could add a new test.

Currently failing tests.. (may not complete, as the whole test suite takes 6 hours on my computer to run, so I am only running the lp.code tests):
- lp.code.browser.tests.test_branchmergeproposal.TestBranchMergeProposalView.test_unmerged_commits_from_deleted_git_ref
- 

Apart from adapting the failing test(s), I would suggest to create a new one which clearly states what gets tested.

I will update the comment once the test run has finished.

P.S.: We will not make you to write a test case, we can do that for you. We would certainly love to know what would prevent you from tryting to set up a launchpad dev environment, as we want to make contributions easier for drive-by contributors.
-- 
https://code.launchpad.net/~addyess/launchpad/+git/launchpad/+merge/473659
Your team Launchpad code reviewers is requested to review the proposed merge of ~addyess/launchpad:bug/lp2081731/internalize-recent-commit-author into launchpad:master.