launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #31552
Re: [Merge] ~ruinedyourlife/launchpad:add-basic-model-for-craft-recipes into launchpad:master
Diff comments:
> diff --git a/lib/lp/crafts/browser/configure.zcml b/lib/lp/crafts/browser/configure.zcml
> new file mode 100644
> index 0000000..812ae95
> --- /dev/null
> +++ b/lib/lp/crafts/browser/configure.zcml
> @@ -0,0 +1,16 @@
> +<!-- Copyright 2024 Canonical Ltd. This software is licensed under the
> + GNU Affero General Public License version 3 (see the file LICENSE).
> +-->
> +
> +<configure
> + xmlns="http://namespaces.zope.org/zope"
> + xmlns:browser="http://namespaces.zope.org/browser"
> + xmlns:i18n="http://namespaces.zope.org/i18n"
> + xmlns:lp="http://namespaces.canonical.com/lp"
> + i18n_domain="launchpad">
> + <lp:facet facet="overview">
> + <lp:url
> + for="lp.crafts.interfaces.craftrecipe.ICraftRecipe"
> + urldata="lp.crafts.browser.craftrecipe.CraftRecipeURL" />
> + </lp:facet>
> +</configure>
> \ No newline at end of file
No newline at end of file.
> diff --git a/lib/lp/crafts/configure.zcml b/lib/lp/crafts/configure.zcml
> new file mode 100644
> index 0000000..fa92a8c
> --- /dev/null
> +++ b/lib/lp/crafts/configure.zcml
> @@ -0,0 +1,43 @@
> +<!-- Copyright 2024 Canonical Ltd. This software is licensed under the
> + GNU Affero General Public License version 3 (see the file LICENSE).
> +-->
> +
> +<configure
> + xmlns="http://namespaces.zope.org/zope"
> + xmlns:browser="http://namespaces.zope.org/browser"
> + xmlns:i18n="http://namespaces.zope.org/i18n"
> + xmlns:lp="http://namespaces.canonical.com/lp"
> + xmlns:xmlrpc="http://namespaces.zope.org/xmlrpc"
> + i18n_domain="launchpad">
> +
> + <lp:authorizations module=".security" />
> + <include package=".browser" />
> +
> + <!-- CraftRecipe -->
> + <class class="lp.crafts.model.craftrecipe.CraftRecipe">
> + <require
> + permission="launchpad.View"
> + interface="lp.crafts.interfaces.craftrecipe.ICraftRecipeView
> + lp.crafts.interfaces.craftrecipe.ICraftRecipeEditableAttributes
> + lp.crafts.interfaces.craftrecipe.ICraftRecipeAdminAttributes" />
> + <require
> + permission="launchpad.Edit"
> + interface="lp.crafts.interfaces.craftrecipe.ICraftRecipeEdit"
> + set_schema="lp.crafts.interfaces.craftrecipe.ICraftRecipeEditableAttributes" />
> + <require
> + permission="launchpad.Admin"
> + set_schema="lp.crafts.interfaces.craftrecipe.ICraftRecipeAdminAttributes" />
> + </class>
> + <subscriber
> + for="lp.crafts.interfaces.craftrecipe.ICraftRecipe
> + zope.lifecycleevent.interfaces.IObjectModifiedEvent"
> + handler="lp.crafts.model.craftrecipe.craft_recipe_modified" />
> +
> + <!-- CraftRecipeSet -->
> + <lp:securedutility
> + class="lp.crafts.model.craftrecipe.CraftRecipeSet"
> + provides="lp.crafts.interfaces.craftrecipe.ICraftRecipeSet">
> + <allow interface="lp.crafts.interfaces.craftrecipe.ICraftRecipeSet" />
> + </lp:securedutility>
> +
> +</configure>
> \ No newline at end of file
No newline prompt.
--
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/473731
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:add-basic-model-for-craft-recipes into launchpad:master.
References