launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+473926@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lpbuildd/target/build_rock.py b/lpbuildd/target/build_rock.py
> index 2da488c..6eeb312 100644
> --- a/lpbuildd/target/build_rock.py
> +++ b/lpbuildd/target/build_rock.py
> @@ -76,7 +87,14 @@ class BuildRock(
>                  "python3-setuptools",
>              ]
>          )
> -        self.backend.run(["apt-get", "-y", "install"] + deps)
> +        if env:

Thank you for the great point! Unfortunately we cannot do that since if we pass None to the function we have to change the whole test suite that is not expecting arguments at all. So in order to be 100% backward compatible with what we have I preferred to use this approach, we can create a ticket to refactor that later :)

> +            self.backend.run(["apt-get", "-y", "install"] + deps, env=env)
> +        else:
> +            self.backend.run(["apt-get", "-y", "install"] + deps)
> +        if self.args.use_fetch_service:
> +            self.install_snapd_proxy(proxy_url=self.args.proxy_url)
> +            self.restart_snapd()
> +            self.configure_git_protocol_v2()
>          if self.backend.supports_snapd:
>              self.snap_store_set_proxy()
>          for snap_name, channel in sorted(self.args.channels.items()):


-- 
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/473926
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad-buildd:fetch-service-apt-initialization into launchpad-buildd:master.