launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+473996@xxxxxxxxxxxxxxxxxx>]

Quentin Debhi has proposed merging ~ruinedyourlife/launchpad:fix-rock-recipe-build-behaviour into launchpad:master.

Commit message:
Remove duplicated check on build_path

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/473996
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:fix-rock-recipe-build-behaviour into launchpad:master.

diff --git a/lib/lp/rocks/model/rockrecipebuildbehaviour.py b/lib/lp/rocks/model/rockrecipebuildbehaviour.py
index 65301ba..51857cc 100644
--- a/lib/lp/rocks/model/rockrecipebuildbehaviour.py
+++ b/lib/lp/rocks/model/rockrecipebuildbehaviour.py
@@ -95,8 +95,6 @@ class RockRecipeBuildBehaviour(BuilderProxyMixin, BuildFarmJobBehaviourBase):
         )
         if build.recipe.build_path is not None:
             args["build_path"] = build.recipe.build_path
-        if build.recipe.build_path is not None:
-            args["build_path"] = build.recipe.build_path
         if build.recipe.git_ref is not None:
             args["git_repository"] = build.recipe.git_repository.git_https_url
             # "git clone -b" doesn't accept full ref names.  If this becomes