launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+474137@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/crafts/adapters/tests/test_buildarch.py b/lib/lp/crafts/adapters/tests/test_buildarch.py
> index 8d2c0f5..a2f5371 100644
> --- a/lib/lp/crafts/adapters/tests/test_buildarch.py
> +++ b/lib/lp/crafts/adapters/tests/test_buildarch.py
> @@ -241,6 +241,52 @@ class TestDetermineInstancesToBuild(WithScenarios, TestCaseWithFactory):
>              },
>          ),
>          (
> +            "build-for as list",

no clue why this slipped in during the rebase
this is already available at https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/474016

> +            {
> +                "sourcecraft_data": {
> +                    "base": "ubuntu@22.04",
> +                    "platforms": {
> +                        "amd64": {"build-for": ["amd64"]},
> +                    },
> +                },
> +                "expected": [("22.04", "amd64")],
> +            },
> +        ),
> +        (
> +            "invalid build-for list",
> +            {
> +                "sourcecraft_data": {
> +                    "base": "ubuntu@22.04",
> +                    "platforms": {
> +                        "amd64": {"build-for": ["amd64", "arm64"]},
> +                    },
> +                },
> +                "expected_exception": MatchesException(
> +                    BadPropertyError,
> +                    "build-for must be a single string or a list with exactly "
> +                    "one element for platform amd64",
> +                ),
> +            },
> +        ),
> +        (
> +            "unsupported architecture",
> +            {
> +                "sourcecraft_data": {
> +                    "base": "ubuntu@22.04",
> +                    "platforms": {
> +                        "mips-arch": {
> +                            "build-on": ["mips"],
> +                            "build-for": "mips",
> +                        },
> +                    },
> +                },
> +                "expected_exception": MatchesException(
> +                    BadPropertyError,
> +                    "Unsupported architecture mips in platform mips-arch",
> +                ),
> +            },
> +        ),
> +        (
>              "bare base",
>              {
>                  "sourcecraft_data": {


-- 
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/474137
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:implement-craft-recipe-requests-builds-job into launchpad:master.