launchpad-reviewers team mailing list archive

[Ines Almeida <mp+474606@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~ines-almeida/launchpad:fix-get-blob-from-store-git into launchpad:master has been updated.

Description changed to:

All tests from `TestGitRefGetBlob` (including the newly added ones) passed.
I also tested locally calling https://git.staging.snapcraftcontent.com/ubuntu/public/snapcraft/e2e-20241001214238/plain/snapcraft.yaml?h=v0.1_beta as an example and it seems to work nicely.

We hardcode the store URLs similarly to how we handle the gitlab case, but we should definitely refactor it to make it more extensible. For now I just hardcoded the 2 staging URLs mentioned by the store folks.

There is also a chance for refactoring in the sense that I mostly copied the code from Launchpad.

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/474606
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fix-get-blob-from-store-git into launchpad:master.