launchpad-reviewers team mailing list archive

[Tushar Gupta <mp+475121@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM, apart from a clarification comment. 

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index 1e241ec..ab1a635 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -166,22 +166,6 @@ applications:
>      charm: ch:rabbitmq-server
>      constraints: "cores=2 mem=8G root-disk=20G {{ extra_constraints }}"
>      num_units: 2
> -  glance-simplestreams-sync-bos01-amd64:

I can see some amd64 non-gpu builders in bos01 set to manual mode on production. Do we need gss and image modifiers units for them or do the builders need to be cleaned up on production ?

> -    charm: {{ charm_dir }}/glance-simplestreams-sync
> -    constraints: "{{ extra_constraints }}"
> -    num_units: 1
> -    options:
> -      content_id_template: "{{ content_id_template }}"
> -      mirror_list: |-
> -        [{url: "http://cloud-images.ubuntu.com/daily/";, name_prefix: "ubuntu:released", path: "streams/v1/index.sjson", max: 3, item_filters: ["release~({{ gss_series }})", "arch~(x86_64|amd64)", "ftype~(disk1.img|disk.img)"]}]
> -      name_prefix: "{{ name_prefix }}/"
> -      openstack-auth-url: "http://keystone.infra.bos01.scalingstack:5000/v3";
> -      openstack-identity-api-version: "3"
> -      openstack-tenant-name: "{{ openstack_tenant_name }}"
> -      openstack-username: "{{ openstack_username }}"
> -      region: scalingstack-bos01
> -      use_swift: false
> -      visibility: private
>    glance-simplestreams-sync-bos01-arm64-gpu:
>      charm: {{ charm_dir }}/glance-simplestreams-sync
>      constraints: "{{ extra_constraints }}"


-- 
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/475121
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.