launchpad-reviewers team mailing list archive

[Guruprasad <mp+475216@xxxxxxxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index d69ffe6..da788e3 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -379,11 +379,7 @@ applications:
>        clamav-database-url: "{{ clamav_database_url }}"
>        launchpad-buildd-repository: "{{ launchpad_buildd_repository }}"
>        linux-command-line-extra: "systemd.unified_cgroup_hierarchy=false"
> -      # XXX cjwatson 2023-11-15: jammy defaults to 5.0/stable, which has
> -      # some race conditions affecting Launchpad builds.  Change this to a
> -      # more stable channel (e.g. 5.20/stable) once one exists that contains
> -      # https://github.com/canonical/lxd/pull/12530.
> -      lxd-channel: "latest/candidate"
> +      lxd-channel: ""

It might be simpler to not specify any value for this key at all and request Matt to set its value to "" in production. This way, we don't have to do one more change to remove this after deploying this change to production.

>        remote-modifiers: '{{ modifiers_bos03 }}'
>        remote-modifier-private-key: include-base64://{{ local_dir }}/id_rsa.imagebuilder
>        remote-modifier-public-key: include-base64://{{ local_dir }}/id_rsa.imagebuilder.pub


-- 
https://code.launchpad.net/~tushar5526/launchpad-mojo-specs/+git/private/+merge/475216
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.