launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:inspectors-configuration-fetch-service into ~launchpad/launchpad-mojo-specs/+git/private:master

To: Simone Pelosi <simone.pelosi@xxxxxxxxxxxxx>
From: Ines Almeida <mp+475344@xxxxxxxxxxxxxxxxxx>
Date: Fri, 18 Oct 2024 10:11:25 -0000
In-reply-to: <172917008311.3159498.8244256385662275426.launchpad@scripts-bzrsyncd.lp.internal>
Reply-to: mp+475344@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

Looked good! As discussed in our call, please remove the `git.launchpad.net` urls, and let's test it :)

For reference, we discussed whether to have the URLs definition at the start of the file as an in-line list or as it is currently here, and decided to leave it as is because these lists can get large and it will be more readable (it is also consistent with our builder proxy specs).

We also discussed the pinning of the vision number, and decided to go for it to make the system more stable.
-- 
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/475344
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:master.

References

[Merge] ~pelpsi/launchpad-mojo-specs/+git/private:inspectors-configuration-fetch-service into ~launchpad/launchpad-mojo-specs/+git/private:master
From: Simone Pelosi, 2024-10-17