launchpad-reviewers team mailing list archive

[Guruprasad <mp+475515@xxxxxxxxxxxxxxxxxx>]

Review: Needs Information



Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index ccb3d79..ba9219c 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -131,7 +131,7 @@
>  {%-   set lp_sshkey = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFrjt0yytzrK9fQuG+6VgE6QStUbDmunlN7+Lv5XhmoL stg-launchpad@launchpad-bastion-ps5" %}
>  {%-   set modifiers_bos01 = '{"arm64": "10.43.0.10"}' %}
>  {%-   set modifiers_bos02 = '{"arm64": "10.44.0.13"}' %}
> -{%-   set modifiers_bos03 = '{"amd64": "10.144.0.206", "arm64": "10.144.0.127", "ppc64el": "10.144.0.110", "riscv64": "10.144.0.114", "s390x": "10.144.0.47"}' %}
> +{%-   set modifiers_bos03 = '{"amd64": "10.144.0.206", "arm64": "10.144.0.127", "arm64-gpu": "10.144.0.178", "ppc64el": "10.144.0.110", "riscv64": "10.144.0.114", "s390x": "10.144.0.47"}' %}

Afaiu, we do not need a separate modifier for the arm64 builders, please see https://chat.canonical.com/canonical/pl/uxmtd4d8jb8atcndhc7xe9rj8e for more context.

>  {%-   set name_prefix = "launchpad-buildd-qastaging" %}
>  {%-   set openstack_tenant_name = "vbuilder_staging_project" %}
>  {%-   set openstack_tenant_name_bos03 = "launchpad-vbuilder-staging_project" %}


-- 
https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/475515
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.