launchpad-reviewers team mailing list archive

[Guruprasad <mp+475412@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/database/schema/patch-2211-30-0.sql b/database/schema/patch-2211-30-0.sql
> new file mode 100644
> index 0000000..111e7ba
> --- /dev/null
> +++ b/database/schema/patch-2211-30-0.sql
> @@ -0,0 +1,19 @@
> +-- Copyright 2024 Canonical Ltd.  This software is licensed under the
> +-- GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +SET client_min_messages=ERROR;
> +
> +ALTER TABLE distribution ADD COLUMN launchpad_templates JSONB;

Just adding to the naming discussion from the other MP, how does 'content_templates' sound? It clearly implies that this contains templates for "some content" in a distribution, distributionsourcepackage, product, ociproject, or project. This can be a bugs, questions etc.

> +ALTER TABLE distributionsourcepackage ADD COLUMN launchpad_templates JSONB;
> +ALTER TABLE product ADD COLUMN launchpad_templates JSONB;
> +ALTER TABLE ociproject ADD COLUMN launchpad_templates JSONB;
> +ALTER TABLE project ADD COLUMN launchpad_templates JSONB;
> +
> +COMMENT ON COLUMN distribution.launchpad_templates IS 'A JSON data structure that contains different templates for Launchpad';
> +COMMENT ON COLUMN distributionsourcepackage.launchpad_templates IS 'A JSON data structure that contains different templates for Launchpad';
> +COMMENT ON COLUMN product.launchpad_templates IS 'A JSON data structure that contains different templates for Launchpad';
> +COMMENT ON COLUMN ociproject.launchpad_templates IS 'A JSON data structure that contains different templates for Launchpad';
> +COMMENT ON COLUMN project.launchpad_templates IS 'A JSON data structure that contains different templates for Launchpad';
> +
> +INSERT INTO LaunchpadDatabaseRevision VALUES (2211, 30, 0);
> +


-- 
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/475412
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:add-lp-templates-db into launchpad:db-devel.