← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~goulinkh/launchpad:goulin-escape-query-params into launchpad:master

 

> [@ikoruk](https://launchpad.net/~ikoruk) wrote:
> 
> Thanks @goulinkh! Can you also add a test specifically for this type of input data: `); some code //` because actually < and > are already escaped by tal it seems but ) and ; and / are not.

Good point [@ikoruk](https://launchpad.net/~ikoruk)! I've added our specific edge case in the tests as well.
-- 
https://code.launchpad.net/~goulinkh/launchpad/+git/launchpad/+merge/476203
Your team Launchpad code reviewers is requested to review the proposed merge of ~goulinkh/launchpad:goulin-escape-query-params into launchpad:master.



References