launchpad-reviewers team mailing list archive

[Ines Almeida <mp+476757@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Incredible work to get `vbuilders_bos01` and `vbuilders_bos02` empty in production :)
Left a couple of minor comments, but looks good.

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index f0dd7c2..a8ba61d 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -37,7 +37,7 @@
>    The image modifiers run on amd64 by default, so the `modifiers_XXX` variables
>    will only be relevant for the remaining archs.
>  #}
> -{%-   set modifiers_bos01 = '{"arm64": "10.43.0.29", "ppc64el": "10.43.0.36"}' %}
> +{%-   set modifiers_bos01 = '{"ppc64el": "10.43.0.36"}' %}

This is possibly a miss from a previous cleanup: AFAIK all of these `modifiers_bos01` and `modifiers_bos02` aren't needed anymore in production. Happy for that to be done in another MP or this one, up to you

>  {%-   set modifiers_bos02 = '{"arm64": "10.44.0.22", "ppc64el": "10.44.0.20"}' %}
>  {%-   set modifiers_bos03 = '{"arm64": "10.143.254.129", "ppc64el": "10.143.254.194", "riscv64": "10.143.254.223", "s390x": "10.143.254.18"}' %}
>  {%-   set name_prefix = "launchpad-buildd" %}
> @@ -139,7 +139,7 @@
>  {%-   set openstack_username = "vbuilder_staging" %}
>  {%-   set openstack_username_bos03 = "launchpad-vbuilder-staging" %}
>  {%-   set openstack_username_lcy02 = "launchpad-vbuilder-staging" %}
> -{%-   set vbuilders_bos01 = {"arm64-gpu": {"arch_base": "arm64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-nvidia-l4", "count": 1, "config_drive": false}} %}

We should also be good to remove the `arm` entry from the `modifiers_bos01` in qastaging

> +{%-   set vbuilders_bos01 = {} %}
>  {%-   set vbuilders_bos02 = {} %}
>  {%-   set vbuilders_bos03 = {"amd64": {"series": "noble", "count": 4}, "amd64-gpu": {"arch_base": "amd64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-gpu", "count": 1}, "arm64": {"series": "noble", "count": 1, "config_drive": false, "flavor": "vbuilder-arm64"}, "arm64-gpu": {"arch_base": "arm64", "arch_suffix": "-gpu", "series": "focal", "flavor": "vbuilder-arm64-gpu", "count": 1}, "ppc64el": {"series": "focal", "count": 3, "config_drive": false, "flavor": "vbuilder-ppc64el"}, "riscv64": {"series": "noble", "count": 1, "config_drive": false}, "s390x": {"series": "focal", "count": 3, "config_drive": false, "flavor": "vbuilder-s390x"}} %}
>  {%-   set vbuilders_lcy02 = {"amd64": {"series": "noble", "count": 4}} %}


-- 
https://code.launchpad.net/~tushar5526/launchpad-mojo-specs/+git/private/+merge/476757
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.