← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~ruinedyourlife/launchpad:artifactory-crate-publishing into launchpad:master

 


Diff comments:

> diff --git a/lib/lp/soyuz/model/archivejob.py b/lib/lp/soyuz/model/archivejob.py
> index 4aeb4c8..d0f126e 100644
> --- a/lib/lp/soyuz/model/archivejob.py
> +++ b/lib/lp/soyuz/model/archivejob.py
> @@ -4,6 +4,7 @@
>  import io
>  import json
>  import logging
> +import os

Is there a reasonable way to do this without `os.walk`, thereby avoiding this dependency altogether?

>  import tarfile
>  import tempfile
>  import zipfile


-- 
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/476755
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:artifactory-crate-publishing into launchpad:master.



References