launchpad-reviewers team mailing list archive

[Tushar Gupta <mp+477198@xxxxxxxxxxxxxxxxxx>]

Tushar Gupta has proposed merging ~tushar5526/launchpad:dont-silence-pip-install-output into launchpad:master.

Commit message:
Don't silence output of install command

Silencing pip install makes it difficult for users to track progress
of the command locally, during buildbot runs etc

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~tushar5526/launchpad/+git/launchpad/+merge/477198
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~tushar5526/launchpad:dont-silence-pip-install-output into launchpad:master.

diff --git a/Makefile b/Makefile
index 7b21bca..3c4c06a 100644
--- a/Makefile
+++ b/Makefile
@@ -330,8 +330,8 @@ $(VENV_INSTANCE_NAME): download-cache requirements/combined.txt setup.py
 		--extra-search-dir=$(WD)/wheels/ \
 		env
 	ln -sfn env/bin bin
-	$(SHHH) $(PIP) install -r requirements/setup.txt
-	$(SHHH) LPCONFIG=$(LPCONFIG) $(PIP) \
+	$(PIP) install -r requirements/setup.txt
+	LPCONFIG=$(LPCONFIG) $(PIP) \
 		install \
 		-c requirements/setup.txt -c requirements/combined.txt -e . \
 		|| { code=$$?; rm -f $@; exit $$code; }