launchpad-reviewers team mailing list archive

[İlker Emre Koç <mp+477329@xxxxxxxxxxxxxxxxxx>]

İlker Emre Koç has proposed merging ~ilkeremrekoc/launchpad:remove-typing-extensions into launchpad:master.

Commit message:
remove typing-extensions package

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilkeremrekoc/launchpad/+git/launchpad/+merge/477329

Removed the typing-extensions package from requirements files and imports in code-base. It was only used in two modules for importing TypedDict class which has been built into python since version=3.8
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilkeremrekoc/launchpad:remove-typing-extensions into launchpad:master.

diff --git a/lib/lp/buildmaster/interfaces/buildfarmjobbehaviour.py b/lib/lp/buildmaster/interfaces/buildfarmjobbehaviour.py
index 7af2fd1..74da7e9 100644
--- a/lib/lp/buildmaster/interfaces/buildfarmjobbehaviour.py
+++ b/lib/lp/buildmaster/interfaces/buildfarmjobbehaviour.py
@@ -8,9 +8,8 @@ __all__ = [
     "IBuildFarmJobBehaviour",
 ]
 
-from typing import Any, Dict, Generator, List, Sequence, Union
+from typing import Any, Dict, Generator, List, Sequence, TypedDict, Union
 
-from typing_extensions import TypedDict
 from zope.interface import Attribute, Interface
 
 
diff --git a/lib/lp/registry/interfaces/distroseries.py b/lib/lp/registry/interfaces/distroseries.py
index 6644891..171b27e 100644
--- a/lib/lp/registry/interfaces/distroseries.py
+++ b/lib/lp/registry/interfaces/distroseries.py
@@ -34,7 +34,6 @@ from lazr.restful.declarations import (
     rename_parameters_as,
 )
 from lazr.restful.fields import CollectionField, Reference, ReferenceChoice
-from typing_extensions import TypedDict
 from zope.component import getUtility
 from zope.interface import Attribute, Interface
 from zope.schema import Bool, Choice, Datetime, List, Object, TextLine
@@ -169,7 +168,7 @@ class DistroSeriesVersionField(UniqueField):
             raise LaunchpadValidationError("'%s': %s" % (version, error))
 
 
-class DistroSeriesTranslationTemplateStatistics(TypedDict):
+class DistroSeriesTranslationTemplateStatistics(typing.TypedDict):
     # The name of the source package that uses the template.
     sourcepackage: str
     # The translation domain for the template.
diff --git a/requirements/launchpad.txt b/requirements/launchpad.txt
index cf5286c..52cb3ac 100644
--- a/requirements/launchpad.txt
+++ b/requirements/launchpad.txt
@@ -180,7 +180,6 @@ treq==18.6.0
 Twisted==20.3.0+lp9
 txfixtures==0.4.3
 txpkgupload==0.5
-typing-extensions==3.10.0.2
 urllib3==1.25.11
 van.testing==3.0.0
 vine==1.3.0
diff --git a/setup.cfg b/setup.cfg
index a08e2f0..b0d97c0 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -110,7 +110,6 @@ install_requires =
     Twisted[conch,tls]
     txfixtures
     txpkgupload
-    typing-extensions
     virtualenv-tools3
     wadllib
     WebOb