launchpad-reviewers team mailing list archive

[Guruprasad <mp+477970@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> === modified file 'master.cfg'
> --- master.cfg	2023-11-20 16:16:56 +0000
> +++ master.cfg	2024-12-09 06:56:05 +0000
> @@ -66,6 +66,16 @@
>      builderNames=["lp-db-devel-focal"],
>      branch='db-devel',
>      treeStableTimer=3*60, treeStableCount=3))
> +c['schedulers'].append(AggregatingScheduler(

Like we discussed last Friday, this should not be using the AggregatingScheduler. and should use the Triggerable scheduler instead. Please see https://bazaar.launchpad.net/~canonical-launchpad-branches/lpbuildbot/public/revision/116 for an example of how to use that.

> +    name="devel-postgres14",

Can you replace all occurrences of 'postgres14' to 'postgresql-14'? Please update the related lpbuildbot-worker MP too, if needed.

> +    builderNames=["lp-devel-focal-postgres14"],
> +    branch='master',
> +    treeStableTimer=3*60, treeStableCount=3))
> +c['schedulers'].append(AggregatingScheduler(
> +    name="db-devel-postgres14",
> +    builderNames=["lp-db-devel-focal-postgres14"],
> +    branch='db-devel',
> +    treeStableTimer=3*60, treeStableCount=3))
>  
>  ####### BUILDERS
>  


-- 
https://code.launchpad.net/~tushar5526/lpbuildbot/add-focal-postgres14-job/+merge/477970
Your team Launchpad code reviewers is subscribed to branch lp:lpbuildbot.