launchpad-reviewers team mailing list archive

[Guruprasad <mp+477970@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM 👍

Diff comments:

> === modified file 'master.cfg'
> --- master.cfg	2023-11-20 16:16:56 +0000
> +++ master.cfg	2024-12-09 09:33:45 +0000
> @@ -183,6 +191,21 @@
>          factory=launchpad_test_factory_factory(
>              '/var/lib/buildbot/slaves/focal-lxd-worker', 'lptests-focal'),
>          locks=[build_lock.access('counting')]),
> +    BuilderConfig(
> +        name='lp-devel-focal-postgresql14',
> +        slavenames=[''],
> +        builddir='lp-devel-focal-postgresql14',
> +        factory=launchpad_test_factory_factory(
> +            # lptests-focal-postgresql14 is the image name created by the lp-buildbot-worker charm

's/is the image name/is the LXD image name'

's/lp-buildbot-worker/lpbuildbot-worker'

> +            '/var/lib/buildbot/slaves/focal-postgresql14-lxd-worker', 'lptests-focal-postgresql14'),
> +        locks=[build_lock.access('counting')]),
> +    BuilderConfig(
> +        name='lp-db-devel-focal-postgresql14',
> +        slavenames=[''],
> +        builddir='lp-db-devel-focal-postgresql14',
> +        factory=launchpad_test_factory_factory(
> +            '/var/lib/buildbot/slaves/focal-postgresql14-lxd-worker', 'lptests-focal-postgresql14'),
> +        locks=[build_lock.access('counting')]),
>      ]
>  
>  ####### STATUS TARGETS


-- 
https://code.launchpad.net/~tushar5526/lpbuildbot/add-focal-postgres14-job/+merge/477970
Your team Launchpad code reviewers is subscribed to branch lp:lpbuildbot.