launchpad-reviewers team mailing list archive

[Tushar Gupta <mp+478295@xxxxxxxxxxxxxxxxxx>]

Tushar Gupta has proposed merging ~tushar5526/lpbuildbot-worker:add-postgresql-16-flavor into lpbuildbot-worker:main.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~tushar5526/lpbuildbot-worker/+git/lpbuildbot-worker/+merge/478295
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~tushar5526/lpbuildbot-worker:add-postgresql-16-flavor into lpbuildbot-worker:main.

diff --git a/create-lp-tests-lxd b/create-lp-tests-lxd
index 24daa0d..a210d80 100755
--- a/create-lp-tests-lxd
+++ b/create-lp-tests-lxd
@@ -74,7 +74,13 @@ FLAVORS = defaultdict(Flavor)
 # validation error. Using "-" will not cause any bugs but skipping it in
 # flavor name will help with catching errors earlier
 FLAVORS["postgresql14"] = Flavor(
-    ["ppa:launchpad/postgresql-ports"], ["launchpad-database-dependencies-14"]
+    extra_ppas=["ppa:launchpad/postgresql-14-ports"],
+    extra_lp_deb_dependencies=["launchpad-database-dependencies-14"],
+)
+
+FLAVORS["postgresql16"] = Flavor(
+    extra_ppas=["ppa:launchpad/postgresql-16-ports"],
+    extra_lp_deb_dependencies=["launchpad-database-dependencies-16"],
 )
 
 
@@ -188,6 +194,9 @@ def install_code(container, series, directory, flavor_name=""):
 
     flavor = FLAVORS[flavor_name]
 
+    # We are installing the flavor PPAs and flavor packages first
+    # so that the packages in flavor PPAs are not shadowed by
+    #  other PPAs
     for ppa in flavor.extra_ppas:
         _exec(container, ["add-apt-repository", "-y", "{}".format(ppa)])