← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~alvarocs/launchpad:content-templates-validator into launchpad:master

 

The proposal to merge ~alvarocs/launchpad:content-templates-validator into launchpad:master has been updated.

Description changed to:

-Make the content_templates field accessible through the API by exporting it.
-Implement new validation function for content templates 'validatie_content_templates' to enforce:
   - allowed keys: types of templates, for now only bug_templates (mergeproposal_templates, answer_templates... in the future).
   - default key: there should be at least one default key for each type of template.
   - checks such as correct types are already built-in the zope.schema.Dict field.
-Add the validation function as constraint of the Dict field .
-Update doctests as 'content_templates' field is now exported.
-Unit tests for validation function.

For more details, see:
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/478379
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:content-templates-validator into launchpad:master.



References