launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #32052
[Merge] ~ikoruk/launchpad:fix-urllib3 into launchpad:master
The proposal to merge ~ikoruk/launchpad:fix-urllib3 into launchpad:master has been updated.
Description changed to:
The `lp.services.tests.test_timeout.TestTimeout.test_urlfetch_timeout_after_listen` test was failing due to `urllib3` being updated to be thread-safe.
With this approach, we pass the `timeout` time explicitly to `session.request` in its `request_kwargs`.
For more details, see:
https://code.launchpad.net/~ikoruk/launchpad/+git/launchpad/+merge/478591
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~ikoruk/launchpad:fix-urllib3 into launchpad:master.
References