launchpad-reviewers team mailing list archive

[İlker Emre Koç <mp+479445@xxxxxxxxxxxxxxxxxx>]

> Why the change from multi-line strings? I find it way more readable with r""",
> is this linter-related?

That was the main problem, actually. The multi-line strings of http requests with "multipart/form-data" content type, for whatever reason, break the multipart's http parsing. The easiest solution was to get rid of the format altogether and be explicit in it. That's why there are a bunch of strings with CRLF endings in there. 

At first, I tried working with multi-line strings as well, but couldn't crack it as to what the problem was with them, and chose this solution as it felt like a good combination of readability, small development-time and working result.
-- 
https://code.launchpad.net/~ilkeremrekoc/launchpad/+git/launchpad/+merge/479445
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilkeremrekoc/launchpad:upgrade-multipart into launchpad:master.