launchpad-reviewers team mailing list archive

[İlker Emre Koç <mp+479445@xxxxxxxxxxxxxxxxxx>]

The comment is used once in each file, and I added it because each file is stored in a completely different place/folder/package. A developer may just stumble upon one of these files without ever touching the other ones, so a new explanation for each file felt important.

And I couldn't create a new function for a similar reason. These 4 files are so dispersed that the complexity added from importing that central function could have an adverse effect on developer understanding while not simplifying the reading enough to warrant its existence. And since the functionality is simple already with only a replacement of "\n", I don't think there is any further need.

But I'm open to implementing further if I made a mistake and/or the alternative proves better once again ^^.

And some other questions like the creation of functions in doctests and/or their import source placements have some parts which would need further explanations as well. Overall, the organization and format of doctests seem to make the usual code organization structures hard to manage.
-- 
https://code.launchpad.net/~ilkeremrekoc/launchpad/+git/launchpad/+merge/479445
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilkeremrekoc/launchpad:upgrade-multipart into launchpad:master.