launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~ilkeremrekoc/launchpad-mojo-specs/+git/private:bugfix-rebuild-images into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder

To: mp+478732@xxxxxxxxxxxxxxxxxx
From: Tushar Gupta <mp+478732@xxxxxxxxxxxxxxxxxx>
Date: Tue, 21 Jan 2025 20:02:29 -0000
In-reply-to: <173470244161.1805286.431744896668936124.launchpad@scripts-bzrsyncd.lp.internal>
Reply-to: mp+478732@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

LGTM. Thanks Ilker. I have approved the MP. Please test this on QAStaging once before merging. 

To test this, you can basically create a patch. Go to QAStaging stg-vbuilder@launchpad-bastion-ps5 and then cd $MOJO_ROOT. Find this file there, apply the changes and then run rebuild image mainfest command. 

Using "history" command will help as well. 

Thanks!
-- 
https://code.launchpad.net/~ilkeremrekoc/launchpad-mojo-specs/+git/private/+merge/478732
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilkeremrekoc/launchpad-mojo-specs/+git/private:bugfix-rebuild-images into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.

References

[Merge] ~ilkeremrekoc/launchpad-mojo-specs/+git/private:bugfix-rebuild-images into ~launchpad/launchpad-mojo-specs/+git/private:vbuilder
From: İlker Emre Koç, 2024-12-20