launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+479919@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/launchpad:upgrade-beautifulsoup-for-real into launchpad:master.

Commit message:
Make doctests compatible with beautifulsoup 4.12.3

And update the beautifulsoup version again, which was previously reverted due to incompatibilities.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/479919
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:upgrade-beautifulsoup-for-real into launchpad:master.

diff --git a/lib/lp/app/stories/launchpad-root/xx-featuredprojects.rst b/lib/lp/app/stories/launchpad-root/xx-featuredprojects.rst
index 79c90bd..38b310a 100644
--- a/lib/lp/app/stories/launchpad-root/xx-featuredprojects.rst
+++ b/lib/lp/app/stories/launchpad-root/xx-featuredprojects.rst
@@ -19,7 +19,7 @@ projects' pages in Launchpad.
     >>> print(extract_text(featured.h2))
     Featured projects
 
-    >>> featured_list = featured.find("", "featured-projects-list")
+    >>> featured_list = featured.find(class_="featured-projects-list")
     >>> for link in featured_list.find_all("a"):
     ...     print(extract_text(link))
     ...
@@ -82,7 +82,7 @@ is now at index '4' and is therefore displayed as the top project:
 
     >>> anon_browser.open("http://launchpad.test/";)
     >>> featured = find_tag_by_id(anon_browser.contents, "homepage-featured")
-    >>> featured_list = featured.find("", "featured-projects-list")
+    >>> featured_list = featured.find(class_="featured-projects-list")
     >>> for link in featured_list.find_all("a"):
     ...     print(extract_text(link))
     ...
diff --git a/lib/lp/translations/stories/importqueue/xx-translation-import-queue.rst b/lib/lp/translations/stories/importqueue/xx-translation-import-queue.rst
index 49ac695..484024e 100644
--- a/lib/lp/translations/stories/importqueue/xx-translation-import-queue.rst
+++ b/lib/lp/translations/stories/importqueue/xx-translation-import-queue.rst
@@ -55,9 +55,9 @@ shown as static HTML.
     >>> print(anon_browser.url)
     http://translations.launchpad.test/firefox/1.0/+imports
     >>> row = find_tags_by_class(anon_browser.contents, "import_entry_row")[1]
-    >>> print(extract_text(row.find("", "import_source")))
+    >>> print(extract_text(row.find(class_="import_source")))
     po/es.po in Mozilla Firefox 1.0 series
-    >>> print(extract_text(row.find("", "import_status")))
+    >>> print(extract_text(row.find(class_="import_status")))
     Needs Review
 
 Some tarballs contain files whose names look like PO or POT files, but
diff --git a/requirements/launchpad.txt b/requirements/launchpad.txt
index 83020ef..57fca91 100644
--- a/requirements/launchpad.txt
+++ b/requirements/launchpad.txt
@@ -17,7 +17,7 @@ backports.functools-lru-cache==1.5
 # ztk-versions.cfg uses 3.2.0 on Python 3, but that drops support for Python
 # 3.5.  Pin to 3.1.7 until we no longer care about xenial.
 bcrypt==3.1.7
-beautifulsoup4==4.7.1
+beautifulsoup4==4.12.3
 billiard==3.6.4.0
 bleach==6.1.0
 bleach-allowlist==1.0.3
@@ -162,7 +162,7 @@ setuptools-git==1.2
 setuptools-scm==3.4.3
 sgmllib3k==1.0.0
 soupmatchers==0.4
-soupsieve==1.9
+soupsieve==2.6
 statsd==3.3.0
 stevedore==1.32.0
 # lp:~launchpad-committers/storm/lp