← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~ruinedyourlife/launchpad:artifactory-env-var-for-sourcecraft-builds into launchpad:master

To: mp+480171@xxxxxxxxxxxxxxxxxx
From: Yuliy Schwartzburg <mp+480171@xxxxxxxxxxxxxxxxxx>
Date: Mon, 27 Jan 2025 16:30:20 -0000
In-reply-to: <173799176207.2854267.4433910747504412926.launchpad@scripts-bzrsyncd.lp.internal>
Reply-to: mp+480171@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Can you please include the tests making sure that non-soss builds can't read these variables?
-- 
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/480171
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:artifactory-env-var-for-sourcecraft-builds into launchpad:master.

References

[Merge] ~ruinedyourlife/launchpad:artifactory-env-var-for-sourcecraft-builds into launchpad:master
From: Quentin Debhi, 2025-01-27