launchpad-reviewers team mailing list archive

[İlker Emre Koç <mp+480299@xxxxxxxxxxxxxxxxxx>]

İlker Emre Koç has proposed merging ~ilkeremrekoc/launchpad:revert-multipart-for-apport into launchpad:master.

Commit message:
revert multipart package for apport bug

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilkeremrekoc/launchpad/+git/launchpad/+merge/480299

The newest versions of multipart package have strict parsing needs, most prominently their strictness over HTTP request line-breaks where they only accept CRLF line-breaks. Meanwhile the bug-report command on Ubuntu in particular and apport package in general uses LF line-breaks on its HTTP requests to Launchpad which breaks the parsing the multipart package does. Ultimately, resulting in a failure to report bugs. As a result, we are temporarily reverting the multipart package upgrade until better fixes on Launchpad and, later, apport package can be published.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilkeremrekoc/launchpad:revert-multipart-for-apport into launchpad:master.

diff --git a/requirements/launchpad.txt b/requirements/launchpad.txt
index 4afe637..665879c 100644
--- a/requirements/launchpad.txt
+++ b/requirements/launchpad.txt
@@ -95,7 +95,7 @@ mistune==0.8.3
 monotonic==1.5
 more-itertools==10.5.0
 msgpack==1.0.2
-multipart==1.2.1
+multipart==0.2.4
 netaddr==0.7.19
 netifaces==0.11.0
 oauth==1.0