launchpad-reviewers team mailing list archive

[Clinton Fung <mp+481421@xxxxxxxxxxxxxxxxxx>]

Clinton Fung has proposed merging ~clinton-fung/launchpad:increase-ensurepresent-timeout-multiplier into launchpad:master.

Commit message:
Increase timeout multiplier for remote ensurepresent() invocation. Terminal failures will take longer to notice, but other cases should benefit from avoiding redoing lost work.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~clinton-fung/launchpad/+git/launchpad/+merge/481421

Increase timeout multiplier for remote ensurepresent() invocation. Terminal failures will take longer to notice, but other cases should benefit from avoiding redoing lost work.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~clinton-fung/launchpad:increase-ensurepresent-timeout-multiplier into launchpad:master.

diff --git a/lib/lp/buildmaster/interactor.py b/lib/lp/buildmaster/interactor.py
index 9bf1a71..fb294c7 100644
--- a/lib/lp/buildmaster/interactor.py
+++ b/lib/lp/buildmaster/interactor.py
@@ -230,7 +230,7 @@ class BuilderWorker:
             self._server.callRemote(
                 "ensurepresent", sha1sum, url, username, password
             ),
-            self.timeout * 5,
+            self.timeout * 20,
         )
 
     def getURL(self, sha1):