launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+480177@xxxxxxxxxxxxxxxxxx>]

I lack the background knowledge about maven and cargo to be able to review this MP.

In general, it would be great to add links to the relevant pieces of documentation, but in the the code as a comment and in the MP, and also explain the important pieces in the commit message.

Please, also go through your changes and add helpful comments where you use special knowledge about maven or cargo, e.g. "create .m2 directory" - I do not know what that is.

Where is the convention of CARGO_ and MAVEN_ prefixes coming from? If this is a custom thing, we need to document that, if that is coming from the languages, it would make sense to add links to the relevant documentation pages.
-- 
https://code.launchpad.net/~ruinedyourlife/launchpad-buildd/+git/launchpad-buildd/+merge/480177
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad-buildd:process-craft-env-vars into launchpad-buildd:master.