launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+480171@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~ruinedyourlife/launchpad:artifactory-env-var-for-sourcecraft-builds into launchpad:master has been updated.

Commit message changed to:

Add artifactory auth and registry environment variables support for craft builds

Similar to how CI builds handle artifactory authentication through environment
variables (see `lib/lp/code/model/cibuildbehaviour.py`), add support for craft
builds to receive artifactory credentials and repo urls through environment variables.

This allows craft builds to authenticate with artifactory registries by:
1. Using the same artifactory.read_credentials config as CI builds
2. Replacing %(read_auth)s placeholders in craftbuild.soss environment_variables
3. Passing the credentials through to the builder as environment variables

The implementation follows the same pattern as `CIBuildBehaviour`'s `build_environment_variables()` function
The builder handles the variables appropriately for different
package managers (cargo, maven, etc).

For more details, see:
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/480171
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:artifactory-env-var-for-sourcecraft-builds into launchpad:master.