launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+481888@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~ruinedyourlife/launchpad:allow-private-resources-sourcecraft-builds into launchpad:master has been updated.

Commit message changed to:

Allow private resources for sourcecraft builds

The build needs access to private resources, in this case, git repos.
We use macaroon, in the same fashion it was done for snap, oci, ci, ... builds.
The similar files for all these builds contain the same kind of code, which was adapted (factory methods not being the same) and the implementation of each build differing a bit.

For more details, see:
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/481888
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:allow-private-resources-sourcecraft-builds into launchpad:master.