launchpad-reviewers team mailing list archive

[Guruprasad <mp+482513@xxxxxxxxxxxxxxxxxx>]

LGTM 👍

Diff comments:

> diff --git a/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-lazr.conf b/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-lazr.conf
> index aed4cdf..20c4d31 100644
> --- a/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-lazr.conf
> +++ b/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-lazr.conf
> @@ -38,3 +38,11 @@ vm_resume_command: ssh -o StrictHostKeyChecking=no -i /home/{{ user }}/.ssh/buil
>  {%- endfor %}
>  {% endif %}
>  
> +{% if craftbuild_config -%}
> +{% for pillar, config in craftbuild_config.items() -%}
> +[craftbuild.{{ pillar }}]

Don't forget to add this section with appropriate default values similar to the ones in the `cibuild.soss` section in `lib/lp/services/config/schema-lazr.conf`.

> +{%- for key, value in config.items() %}
> +{{ key }}: {{ json.dumps(value) }}
> +{%- endfor %}
> +{%- endfor %}
> +{% endif %}


-- 
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/482513
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:lazr-conf-craft-builds into launchpad:master.