← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~jnsgruk/launchpad-buildd:proxy-vars-uppercase into launchpad-buildd:master

 

Where I've run into it most is building electron apps - the electron builder seems to only look for uppercase variants: https://github.com/gajus/global-agent/blob/v2.1.5/README.md#environment-variables

An example in the wild: https://github.com/snapcrafters/signal-desktop/blob/a5e07a78605da7819f6dd6c4f62d31c16ee5610d/snap/snapcraft.yaml#L65-L69

I'll take a look at making the changes you mention and revert back shortly.
-- 
https://code.launchpad.net/~jnsgruk/launchpad-buildd/+git/launchpad-buildd/+merge/482529
Your team Launchpad code reviewers is requested to review the proposed merge of ~jnsgruk/launchpad-buildd:proxy-vars-uppercase into launchpad-buildd:master.



References